On Mon, Oct 19, 2020 at 08:10:56PM -0700, Junio C Hamano wrote: > Taylor Blau <me@xxxxxxxxxxxx> writes: > > >> echo change$i >unrelated-file$i && > >> - seq 1000 | tac >>unrelated-file$i && > >> + test_seq 1000 | tac >>unrelated-file$i && > > > > Makes sense. I wouldn't be opposed to breaking this out into an earlier > > change (e.g., "it's about to become not OK to use seq in t/perf, so > > prepare for that by replacing any invocations with test_seq()"), but I > > think it's probably not worth it, since this patch is small as it is. > > test_seq is fine, but I do not think tac is portable (only saved by > the fact that not many people, especially on exotic platforms, run > perf scripts). Serves me right for reading while I'm tired! I glazed right over 'tac'. If you need a truly unrelated file, you could write random data into it (there are some examples in t/test-lib-functions.sh), but I'd just write 'test_seq 1001'. Thanks, Taylor
