On Mon, Oct 19, 2020 at 03:17:02PM -0700, Junio C Hamano wrote: > Taylor Blau <me@xxxxxxxxxxxx> writes: > > > I think that the 3-patch series that Junio was talking about in [1] is > > actually this one [2]. > > ... > > [1]: https://lore.kernel.org/git/xmqqmu0it6ls.fsf@xxxxxxxxxxxxxxxxxxxxxx/ > > [2]: https://lore.kernel.org/git/20201018194912.2716372-1-gitster@xxxxxxxxx/ > > True. > > I actually think it is a bad idea to add ":" after every mention of > "Signed-off-by"; it only looks clarifying because we use a boring > and generic word "line" to refer to where that three-word token > appears. > > We can say "a 'Signed-off-by' trailer" and it becomes plenty clear > that we are not talking about any random line in the log message, > and we do not need ":" everywhere, I suspect. Mm. I may be in the minority that I think having ":" after "Signed-off-by" is helpful, but I'm happy to go whichever way others find most clear. > Thanks. Thanks, Taylor
