Re: [PATCH] dir.c: fix comments to agree with argument name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH] dir.c: fix comments to agree with argument name
From: Junio C Hamano <gitster@xxxxxxxxx>
Date: Thu, 15 Oct 2020 13:23:29 -0700
Cc: Nipunn Koorapati via GitGitGadget <gitgitgadget@xxxxxxxxx>, git@xxxxxxxxxxxxxxx, Nipunn Koorapati <nipunn1313@xxxxxxxxx>, Alex Vandiver <alexmv@xxxxxxxxxxx>
In-reply-to: <20201015194158.GA1490964@coredump.intra.peff.net> (Jeff King's message of "Thu, 15 Oct 2020 15:41:58 -0400")
References: <pull.757.git.1602766160815.gitgitgadget@gmail.com> <20201015160725.GA1104947@coredump.intra.peff.net> <xmqqk0vrfi1r.fsf@gitster.c.googlers.com> <20201015194158.GA1490964@coredump.intra.peff.net>
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

Jeff King <peff@xxxxxxxx> writes:

>> Anyway.  Nipunn, can you fix both of them in the same commit, as
>> they are addressing a problem from the same cause (i.e. we are no
>> longer SHA-1 centric).
>
> The v2 that Nipunn sent with "oid" in the comment looks good to me.

OK, then all is good.  Thanks.

Follow-Ups:
- Re: [PATCH] dir.c: fix comments to agree with argument name
  - From: Nipunn Koorapati

References:
- [PATCH] dir.c: fix comments to agree with argument name
  - From: Nipunn Koorapati via GitGitGadget
- Re: [PATCH] dir.c: fix comments to agree with argument name
  - From: Jeff King
- Re: [PATCH] dir.c: fix comments to agree with argument name
  - From: Junio C Hamano
- Re: [PATCH] dir.c: fix comments to agree with argument name
  - From: Jeff King

Prev by Date: Re: [PATCH] fast-import: fix over-allocation of marks storage
Next by Date: Re: [PATCH v11 0/7] Finish converting git bisect to C part 2 subset 2
Previous by thread: Re: [PATCH] dir.c: fix comments to agree with argument name
Next by thread: Re: [PATCH] dir.c: fix comments to agree with argument name
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]