On Thu, Oct 15, 2020 at 12:49:20PM +0000, Nipunn Koorapati via GitGitGadget wrote: > diff --git a/dir.c b/dir.c > index 78387110e6..4c79c4f0e1 100644 > --- a/dir.c > +++ b/dir.c > @@ -1040,9 +1040,9 @@ static int add_patterns_from_buffer(char *buf, size_t size, > * an index if 'istate' is non-null), parse it and store the > * exclude rules in "pl". > * > - * If "ss" is not NULL, compute SHA-1 of the exclude file and fill > + * If "oid_stat" is not NULL, compute SHA-1 of the exclude file and fill Makes sense. This changed as part of 4b33e60201 (dir: convert struct sha1_stat to use object_id, 2018-01-28). Perhaps it would likewise make sense to stop saying "SHA-1" here, and just say "hash" (or even "object id", though TBH I think the fact that the hash is the same as an object-id is largely an implementation detail). -Peff
