On Tue, Oct 13, 2020 at 3:14 PM Junio C Hamano <gitster@xxxxxxxxx> wrote:
>
> Sean McAllister <smcallis@xxxxxxxxxx> writes:
>
> > test_expect_success 'partial clone using HTTP with redirect' '
> > - _NONCE=`gen_nonce` && export _NONCE &&
> > + _NONCE=$(gen_nonce) &&
> > curl "$HTTPD_URL/error_ntime/${_NONCE}/3/502/10/smart/server" &&
> > curl "$HTTPD_URL/error_ntime/${_NONCE}/3/502/10/smart/server" &&
> > curl "$HTTPD_URL/error_ntime/${_NONCE}/3/502/10/smart/server" &&
> > partial_clone "$HTTPD_DOCUMENT_ROOT_PATH/server" "$HTTPD_URL/error_ntime/${_NONCE}/3/502/10/smart/server"
>
> It also bothers me somewhat that we waste 40 seconds waiting to
> complete this test, most of the time just sleeping.
>
> Now, do we still need gen_nonce in the test library, now there is
> only one or two tests, both in a single test script?
>
> Thanks.
In the last patch of the series I actually knocked these down to 1
second because the delay was obnoxious, I agree. I'll update it so
that it's done in this patch and I'll move gen_nonce.
I'll be a little bit delayed with v3 since my workstation decided to
explode last night :(
