Hi Peff, On Fri, 2 Oct 2020, Jeff King wrote: > On Fri, Oct 02, 2020 at 01:37:23PM +0200, Johannes Schindelin wrote: > > > But I would highly doubt that the empty lines were the biggest problem: > > Sure, we would fail to recognize an empty line with CR/LF line endings > > when reading with `strbuf_getline_lf()`, but we would totally > > misunderstand the entire rest of the lines, too. For example, we would > > mistake `quit\r` for an unknown command, and hence simply ignore it. > > > > I do agree, however, that your confusion validly points out a flaw in the > > commit message: the "empty line" comment is a red herring. > > > > Therefore, I spent some time pouring over the commit message. This is my > > current version: > > [...] > > What do you think? > > I think we are on the same page, and this revision does a good job of > fixing my complaint about the commit message. Thanks. One minor typo: > > > While we do this for the credential helper protocol, we do _not_ do > > adjust `git credential-cache--daemon` (which won't work on Windows, > > s/do$// Thanks, fixed! Ciao, Dscho
