This contribution came in via Git for Windows [https://github.com/git-for-windows/git/pull/2516]. Sadly, I did not find the time to go through all the changes of 8f309aeb ("strbuf: introduce strbuf_getline_{lf,nul}()", 2016-01-13) (as Junio asked [https://public-inbox.org/git/xmqqmu9lnjdh.fsf@xxxxxxxxxxxxxxxxxxxxxxxxx]). Rather than delaying this patch indefinitely, I admit defeat on that angle. Changes since v1: * Added a commit to adjust credential-daemon and credential-store in the same manner. * Adjusted the documentation accordingly. Nikita Leonov (3): credential.c: fix credential reading with regards to CR/LF credentials: make line reading Windows compatible docs: make notes regarding credential line reading Documentation/git-credential.txt | 4 +++- Documentation/gitcredentials.txt | 2 ++ builtin/credential-cache--daemon.c | 4 ++-- builtin/credential-store.c | 2 +- credential.c | 2 +- t/t0302-credential-store.sh | 16 ++++++---------- 6 files changed, 15 insertions(+), 15 deletions(-) base-commit: 9bc233ae1cf19a49e51842c7959d80a675dbd1c0 Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-710%2Fdscho%2Fcrlf-aware-git-credential-v2 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-710/dscho/crlf-aware-git-credential-v2 Pull-Request: https://github.com/git/git/pull/710 Range-diff vs v1: 1: 2a9cc710bb = 1: 27f6400a21 credential.c: fix credential reading with regards to CR/LF -: ---------- > 2: f69076036f credentials: make line reading Windows compatible -: ---------- > 3: 61baea1061 docs: make notes regarding credential line reading -- gitgitgadget
