Re: [PATCH v3 08/11] cmake (Windows): initialize vcpkg/build dependencies automatically

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v3 08/11] cmake (Windows): initialize vcpkg/build dependencies automatically
From: Sibi Siddharthan <sibisiddharthan.github@xxxxxxxxx>
Date: Tue, 29 Sep 2020 12:21:07 +0530
Cc: git@xxxxxxxxxxxxxxx, Đoàn Trần Công Danh <congdanhqx@xxxxxxxxx>, SZEDER Gábor <szeder.dev@xxxxxxxxx>, Eric Sunshine <sunshine@xxxxxxxxxxxxx>, Johannes Schindelin <Johannes.Schindelin@xxxxxx>, Øystein Walle <oystwa@xxxxxxxxx>
In-reply-to: <7c1601c7e351855fd720df05efc44440374792ce.1601327357.git.gitgitgadget@gmail.com>
References: <pull.738.v2.git.1601155970.gitgitgadget@gmail.com> <pull.738.v3.git.1601327357.gitgitgadget@gmail.com> <7c1601c7e351855fd720df05efc44440374792ce.1601327357.git.gitgitgadget@gmail.com>

>  if(WIN32)
>         set(VCPKG_DIR "${CMAKE_SOURCE_DIR}/compat/vcbuild/vcpkg")
> +       if(NOT EXISTS ${VCPKG_DIR})
> +               message("Initializinge vcpkg and building the Git's dependencies (this will take a while...)")
         I think you meant Initializing. (Nitpicking :) )

Thank You,
Sibi Siddharthan

Follow-Ups:
- Re: [PATCH v3 08/11] cmake (Windows): initialize vcpkg/build dependencies automatically
  - From: Johannes Schindelin

References:
- [PATCH v2 00/10] CMake and Visual Studio
  - From: Johannes Schindelin via GitGitGadget
- [PATCH v3 00/11] CMake and Visual Studio
  - From: Johannes Schindelin via GitGitGadget
- [PATCH v3 08/11] cmake (Windows): initialize vcpkg/build dependencies automatically
  - From: Johannes Schindelin via GitGitGadget

Prev by Date: Re: [PATCH] git-completion.bash: stash-show: add --patch-with-stat
Next by Date: [PATCH] diff: get rid of redundant 'dense' argument
Previous by thread: [PATCH v3 08/11] cmake (Windows): initialize vcpkg/build dependencies automatically
Next by thread: Re: [PATCH v3 08/11] cmake (Windows): initialize vcpkg/build dependencies automatically
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]