The intention of this patch series is to make it as easy as possible for a Visual Studio user to start building Git from scratch. The idea is to * clone Git's source code, * open it in Visual Studio via File>Open>Folder... * let CMake configure things (and vcpkg build the dependencies, which will take a while), and * start the build. It does require a Git for Windows to be installed so that the source can be cloned, but also to run the shell script parts of the CMake configuration, and also to run the tests. This patch series replaces the patch "Ignore files generated by CMake" I sent via https://github.com/gitgitgadget/git/pull/735. Changes since v2: * Fixed a typo in the message when msgfmt.exe is not found. * Simplified the logic to find sh.exe (thanks Øystein). Changes since v1: * Touched up a couple commit messages in response to reviewer comments * Adjusted the instructions at the top of CMakeLists.txt so that the part talking about running CMake manually also talks about using contrib/buildsystems/out/ as build directory (in line with the part talking about Visual Studio's out-of-the-box experience) * Replaced patch 10/10 with Junio's much more elegant solution of editing the hashmap_for_each_entry() macro instead of all of its callers. Johannes Schindelin (10): cmake: ignore files generated by CMake as run in Visual Studio cmake: do find Git for Windows' shell interpreter cmake: ensure that the `vcpkg` packages are found on Windows cmake: fall back to using `vcpkg`'s `msgfmt.exe` on Windows cmake: quote the path accurately when editing `test-lib.sh` cmake (Windows): let the `.dll` files be found when running the tests cmake (Windows): complain when encountering an unknown compiler cmake (Windows): initialize vcpkg/build dependencies automatically cmake (Windows): recommend using Visual Studio's built-in CMake support cmake: fix typo in message when `msgfmt` was not found Junio C Hamano (1): hashmap_for_each_entry(): workaround MSVC's runtime check failure #3 .gitignore | 1 + contrib/buildsystems/CMakeLists.txt | 52 ++++++++++++++++++++++------- hashmap.h | 3 +- 3 files changed, 43 insertions(+), 13 deletions(-) base-commit: 9bc233ae1cf19a49e51842c7959d80a675dbd1c0 Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-738%2Fdscho%2Fcmake-and-visual-studio-v3 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-738/dscho/cmake-and-visual-studio-v3 Pull-Request: https://github.com/gitgitgadget/git/pull/738 Range-diff vs v2: 1: ba314373e9 = 1: 9c7a964519 cmake: ignore files generated by CMake as run in Visual Studio 2: 05b4b69fee < -: ---------- cmake: do find Git for Windows' shell interpreter -: ---------- > 2: 3b467360bb cmake: do find Git for Windows' shell interpreter 3: 5967822a0c ! 3: a49b28e001 cmake: ensure that the `vcpkg` packages are found on Windows @@ contrib/buildsystems/CMakeLists.txt: cmake_minimum_required(VERSION 3.14) + set(CURL_NO_CURL_CMAKE ON) +endif() - find_program(SH_EXE sh) + find_program(SH_EXE sh PATHS "C:/Program Files/Git/bin") if(NOT SH_EXE) 4: efc93f1dd9 = 4: f1baf0f974 cmake: fall back to using `vcpkg`'s `msgfmt.exe` on Windows 5: 8b3500a07c = 5: 8380aa55ab cmake: quote the path accurately when editing `test-lib.sh` 6: 88abbd9a78 = 6: f61c3ef442 cmake (Windows): let the `.dll` files be found when running the tests 7: 26ebeecb14 = 7: 7a4346a437 cmake (Windows): complain when encountering an unknown compiler 8: 3587ee5e8d = 8: 7c1601c7e3 cmake (Windows): initialize vcpkg/build dependencies automatically 9: 68a7d984ec = 9: ec182738f0 cmake (Windows): recommend using Visual Studio's built-in CMake support 10: 152705bbc6 = 10: 38cef4deb5 hashmap_for_each_entry(): workaround MSVC's runtime check failure #3 -: ---------- > 11: c3e235fe39 cmake: fix typo in message when `msgfmt` was not found -- gitgitgadget
