Carlo Arenas <carenas@xxxxxxxxx> writes: >> -test_expect_success 'get: credentials with DOS line endings are invalid if path is relevant' ' >> +test_expect_success 'get: credentials with DOS line endings are valid if path is relevant' ' > > note that this test was put in place to protect users from regressions > like the one we got after the release of 2.26.1 where users that had > '\r' as part of their credentials were getting an error[1] > > while I am sympathetic to the change (indeed I proposed something > similar, but was reminded by Peff that while it looks like a text file > it was designed to be considered opaque and therefore should use UNIX > LF as record terminator by specification), I am concerned this could > result in a similar regression since we know they are still users out > there that had modified this file manually (something that was not > recommended) and are currently relying on the fact that these lines > are invalid and therefore silently ignored. > > Carlo > > [1] https://lore.kernel.org/git/ad80aa0d-3a35-6d7e-7958-b3520e16c855@xxxxxxx/ I think you meant to remind us and this thread of the earlier review and discussion thread, which begins at https://lore.kernel.org/git/20200426234750.40418-1-carenas@xxxxxxxxx/ And thanks for doing so---I totally forgot about it.
