Hi Junio, On Mon, 21 Sep 2020, Junio C Hamano wrote: > "Johannes Schindelin via GitGitGadget" <gitgitgadget@xxxxxxxxx> > writes: > > > From: Johannes Schindelin <johannes.schindelin@xxxxxx> > > > > The completion tests used that name unnecessarily, and it is a > > non-inclusive term, so let's avoid using it here. > > > > Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx> > > --- > > t/t9902-completion.sh | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > Here, the tests and the tested feature do not work any differently > on the first-made branch, so the same "just use topic, not the > first-made branch name" used in 3/5 applies here. > > Luckily, unlike 3/5 and 4/5, this step does not involve names > derived from the name of the first-made branch name, so 'main' > may be OK as-is, but for consistency across the patches, we may > want to consider using 'topic' here as well. I dunno. I am afraid that three test cases that are touched by this test rely on the fact that the first two letters (or just the first letter) are ambiguous when tab-completing branch names: `ma` could complete to either `master` or `maint`. To clarify, I added a paragraph to the commit message. Ciao, Dscho
