On 9/11/2020 5:02 PM, Junio C Hamano wrote: > Derrick Stolee <stolee@xxxxxxxxx> writes: > >>> +test_expect_success 'disallows --bare with --origin' ' >>> + >>> + test_expect_code 128 git clone -o foo --bare parent clone-bare-o 2>err && >>> + test_debug "cat err" && >>> + test_i18ngrep "\-\-bare and --origin foo options are incompatible" err >>> + >>> +' >> >> It seems that all of your tests have an extraneous newline >> at the end. > > That matches the older style to make the test body stand out by > having blank lines around it. All existing tests from the era (not > limited to this script) used to do so. > > It is OK to update them to modern style, but let's not do so in the > middle of the series. Thanks for correcting me. (and Peff for doing the same). I should have looked at the context better, because that is frequently the reason for "inconsistent" style. My apologies. -Stolee
