On 9/11/2020 2:25 PM, Sean Barag via GitGitGadget wrote: > From: Sean Barag <sean@xxxxxxxxx> > > Some combinations of command-line options to `git clone` are invalid, > but there were previously no tests ensuring those combinations reported > errors. Similarly, `git clone --template` didn't appear to have any > tests. > > Signed-off-by: Sean Barag <sean@xxxxxxxxx> > --- > t/t5606-clone-options.sh | 44 ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/t/t5606-clone-options.sh b/t/t5606-clone-options.sh > index e69427f881..d20a78f84b 100755 > --- a/t/t5606-clone-options.sh > +++ b/t/t5606-clone-options.sh > @@ -19,6 +19,50 @@ test_expect_success 'clone -o' ' > > ' > > +test_expect_success 'disallows --bare with --origin' ' > + > + test_expect_code 128 git clone -o foo --bare parent clone-bare-o 2>err && > + test_debug "cat err" && > + test_i18ngrep "\-\-bare and --origin foo options are incompatible" err > + > +' It seems that all of your tests have an extraneous newline at the end. Thanks, -Stolee
