On Thu, Sep 03, 2020 at 12:42:25PM -0400, Taylor Blau wrote: > On Wed, Aug 19, 2020 at 10:20:21AM +0200, SZEDER Gábor wrote: > > On Tue, Aug 11, 2020 at 04:52:14PM -0400, Taylor Blau wrote: > > > Introduce a command-line flag and configuration variable to fill in the > > > 'max_new_filters' variable introduced by the previous patch. > > > > > > The command-line option '--max-new-filters' takes precedence over > > > 'commitGraph.maxNewFilters', which is the default value. > > > '--no-max-new-filters' can also be provided, which sets the value back > > > to '-1', indicating that an unlimited number of new Bloom filters may be > > > generated. (OPT_INTEGER only allows setting the '--no-' variant back to > > > '0', hence a custom callback was used instead). > > > > Forgot the most important thing: Why? Please explain in the commit > > message why this option is necesary, what problems does it solve, > > how it is supposed to interact with other options and why so. > > This is already explained in detail in the patch 'commit-graph: add > large-filters bitmap chunk', although there is an error in the quoted > part of your email (which I wrote) which refers the reader to the > previous patch. The patch I'm actually referring two is the > twice-previous patch. The proposed log message of that patch only briefly mentions what this option will do, and goes into detail about what problems it _causes_ and how that new chunk is supposed to solve _those_ problems. It does not explain what problems this new option is supposed to solve, and why would anyone want to use this option. > I'll fix that locally before re-sending. > > Thanks, > Taylor
