On Tue, Aug 11, 2020 at 04:52:14PM -0400, Taylor Blau wrote: > Introduce a command-line flag and configuration variable to fill in the > 'max_new_filters' variable introduced by the previous patch. > > The command-line option '--max-new-filters' takes precedence over > 'commitGraph.maxNewFilters', which is the default value. > '--no-max-new-filters' can also be provided, which sets the value back > to '-1', indicating that an unlimited number of new Bloom filters may be > generated. (OPT_INTEGER only allows setting the '--no-' variant back to > '0', hence a custom callback was used instead). Forgot the most important thing: Why? Please explain in the commit message why this option is necesary, what problems does it solve, how it is supposed to interact with other options and why so.
