On Mon, Aug 17, 2020 at 09:58:54AM -0700, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > Where do we want to go with this? After the discussion and sleeping on > > it, I'm still of the mind that we should generally default things to > > being builtins unless there's an immediate need not to do so (like > > extra link dependencies). But I don't care _too_ much, so I'd rather > > eject this patch and move forward with the rest of the series if it's a > > sticking point. Thoughts? > > I already said what needs to be said. I guess my question was really: after the discussion do you think I'm being an idiot, to the point that you do not want to pick up the series? It sounds like the answer is no, and... > I do not care too deeply what we do now today either way, as long as > people remember that we are interested in the version string, build > options and external library versions of the "git" binary (for > built-ins) and non-built-in binaries (like the remote helpers), and > not as much interested in these traits of the "git-bugreport" binary > itself, when we need to split "bugreport" out of builtins in the > future. Yes, I agree that future changes to bugreport may need to keep that in mind (but my guess is that it won't even ever come up). -Peff
