On Thu, Aug 13, 2020 at 10:59:36AM -0400, Jeff King wrote: > > There's no reason that bugreport has to be a separate binary. And since > it links against libgit.a, it has a rather large disk footprint. Let's > make it a builtin, which reduces the size of a stripped installation > from 24MB to 22MB. > > This also simplifies our Makefile a bit. And we can take advantage of > builtin niceties like RUN_SETUP_GENTLY. > > Signed-off-by: Jeff King <peff@xxxxxxxx> > --- > Makefile | 6 +----- > builtin.h | 1 + > bugreport.c => builtin/bugreport.c | 10 +++------- > contrib/buildsystems/CMakeLists.txt | 5 +---- > git.c | 1 + > 5 files changed, 7 insertions(+), 16 deletions(-) > rename bugreport.c => builtin/bugreport.c (96%) And I saw no surprises in the diff. As stated in https://lore.kernel.org/git/20200817121239.GA44309@xxxxxxxxxx I think this is a fine idea, so: Reviewed-by: Emily Shaffer <emilyshaffer@xxxxxxxxxx>
