Hi Peff, On Fri, 14 Aug 2020, Jeff King wrote: > On Fri, Aug 14, 2020 at 04:18:37PM +0200, Johannes Schindelin wrote: > > > While all four methods work, the only one that is regularly used with the > > `make install` command is the first one. > > > > The location you modified is in the `MSVC` part of `compat.mak.uname`, > > i.e. in the Visual C part. > > > > We originally had a tentative plan to eventually, maybe, build Git for > > Windows using Visual C by default. However, it turned out that the > > standard malloc in Visual C's runtime was tuned for other workloads than > > Gits, and that nedmalloc performed better, and we originally could not get > > nedmalloc to compile with a modern Visual C, so we stopped that effort. > > > > That's why you still have support for `make MSVC=1 install`. > > > > Since it seems not to be too much trouble, I would prefer to keep it > > working for now, even if it is rarely exercised and regressions might > > creep in (like the ones you fixed). > > Ah, thanks. That perfectly explains what is going on and why it might > not have been noticed. I agree it is not too much trouble to keep it > around for now. Incidentally, I stumbled across the patch I carry in Git for Windows' branch thicket that _actually_ fixes this. Will send it out in a couple minutes. Ciao, Dscho
