On Fri, 14 Aug 2020 at 14:31, Derrick Stolee <stolee@xxxxxxxxx> wrote: > > On 8/14/2020 8:21 AM, Martin Ågren wrote: > > > > If the upload-pack server advertises this capability, fetch-pack may > > -send "want" lines with SHA-1s that exist at the server but are not > > -advertised by upload-pack. > > +send "want" lines with object names that exist at the server but are not > > +advertised by upload-pack. (Note that the name of the capability > > +contains "sha1", but that it's more general than that: in SHA-1 > > +repositories, the "want" lines provide SHA-1 values, but in SHA-256 > > +repositories, they provide SHA-256 values.) > > > > allow-reachable-sha1-in-want > > ---------------------------- > > > > If the upload-pack server advertises this capability, fetch-pack may > > -send "want" lines with SHA-1s that exist at the server but are not > > -advertised by upload-pack. > > +send "want" lines with object names that exist at the server but are not > > +advertised by upload-pack. (Same remark about "sha1" as above.) > > This "as above" is brittle to future changes. Fair enough. :-) I actually thought this might be *less* brittle, since we wouldn't need to do any additional changes twice. > I think it > could be improved with > > (As in "allow-tip-sha1-in-want", the "sha1" in this capability > refers to object names, not the hash algorithm chosen for the > repository.) > > Or, just repeat the same note again. These two paragraphs are identical before this patch, so it might make sense not to change that property. Thanks. Martin
