On Wed, 5 Aug 2020 at 12:03, Jeff King <peff@xxxxxxxx> wrote: > > On Wed, Aug 05, 2020 at 11:27:22AM +0200, Martin Ågren wrote: > > > > - grep "tree filter allows max depth 0, but got 1" err > > > + test_i18ngrep "tree filter allows max depth 0, but got 1" err > > > > This one isn't translated, so this hunk could be dropped. Or maybe you > > wanted to knowingly cast a slightly wider net? (And this does fit the > > subject of your patch.) > > Neither message is translated in itself, but the bug can happen with > either of them (because of the translation of the "remote error" > string). The tree-depth one was actually in the first failure I saw, but > when I re-ran it to produce output for the commit message, I got one of > the other tests. Braino! Thanks for (re-)explaining so patiently. I even tried dropping that hunk and running a fair amount of "--stress" -- never failed. Without the other hunks, "--stress" hit the failure pretty much instantly. Oh well, brute force doesn't always beat actual thinking. Martin
