On Wed, Aug 05, 2020 at 11:27:22AM +0200, Martin Ågren wrote: > > In theory we'd see both copies of the message in the second case. But > > now always! As soon as the client sees ERR, it exits and we run grep. > > s/now/not/ Oops, thanks. > > - grep "filter '\''blob:none'\'' not supported" err > > + test_i18ngrep "filter '\''blob:none'\'' not supported" err > > Right, this is the one from the intro and the commit message. > > > - grep "tree filter allows max depth 0, but got 1" err > > + test_i18ngrep "tree filter allows max depth 0, but got 1" err > > This one isn't translated, so this hunk could be dropped. Or maybe you > wanted to knowingly cast a slightly wider net? (And this does fit the > subject of your patch.) Neither message is translated in itself, but the bug can happen with either of them (because of the translation of the "remote error" string). The tree-depth one was actually in the first failure I saw, but when I re-ran it to produce output for the commit message, I got one of the other tests. -Peff
