On Wed, Jul 29, 2020 at 5:52 PM Jeff King <peff@xxxxxxxx> wrote:
>
> There might be room for an easy feature there, too. If we're given url A
> on the command line and then we convert it to B with insteadOf, it's not
> clear to me which one is the thing we should write into the merge
> message.
You're right, and I actually considered doing that originally.
The reason I ended up with my hook is that a number of people send me
their pull requests using the ssh address anyway, because they as
maintainers end up having kernel.org accounts, and that's how they
interact with it.
So I actually end up wanting to rewrite it to use the public address
even if the insteadOf logic didn't trigger, because those ssh
addresses just don't make sense in the public history, and there's an
easy 1:1 translation to the public mirrors.
> And while it's definitely a special case, I suspect it may be one that
> other folks have, too (e.g., mentioning https:// URLs is probably more
> friendly than ssh for most people).
Now there I agree - I suspect a lot of developers inside various
companies have "this is the internal mirror I use, because
firewalls/bandwidth/whatever", but they might not necessarily want
that internal choice be reflected in their log messages.
That said, I'm just _imagining_ that to be true. I might be reading
too much into my own habits.
Linus
