Re: [PATCH v5 02/13] bisect--helper: use '-res' in 'cmd_bisect__helper' return

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Following 'enum bisect_error' vocabulary, return variable 'res' is
> always non-positive.
> Let's use '-res' instead of 'abs(res)' to make the code clearer.

> Mentored-by: Christian Couder <chriscool@xxxxxxxxxxxxx>
> Signed-off-by: Miriam Rubio <mirucam@xxxxxxxxx>
> Helped-by: Junio C Hamano <gitster@xxxxxxxxx>

Although there is no set rule for this, but I think that your sign-off
goes at the last generally. This is what I have seen on various patches.




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux