Hello Miriam,
> In cmd_bisect__helper() function, there would be a bug
> if an invalid or no subcommand was passed.return error()
> should be replaced by BUG() in that case.
> Mentored-by: Christian Couder <chriscool@xxxxxxxxxxxxx>
> Mentored-by: Johannes Schindelin <Johannes.Schindelin@xxxxxx>
> Signed-off-by: Miriam Rubio <mirucam@xxxxxxxxx>
> ---
I think we can try for a better message. Maybe something like:
One encounters a BUG when an invalid or no subcommand is passed to
'cmd_bisect__helper()'. BUG() out instead of returning an error.
> - return error("BUG: unknown subcommand '%d'", cmdmode);
> + BUG("unknown subcommand %d", (int)cmdmode);
Do we need to typecast an integer to an integer here?
Regards,
Shourya Shukla
