On 2020-07-10 at 15:14:37, Derrick Stolee wrote: > On 7/9/2020 10:46 PM, brian m. carlson wrote: > > This is the final part required for the stage 4 implementation of > > SHA-256. > > WOOHOO! What a milestone! I'm also excited about this. It's been a lot of work, but we're finally here. > As usual, your commits are excellently organized and clear. I could > not find any fault in any of them. Thanks. > The proof is really in the pudding: does this pass the test suite > when GIT_TEST_DEFAULT_HASH=sha256? You add that as a mode to the > CI scripts, so we will know. I've seen several cases where we've accidentally regressed things with SHA-256, so it seemed only prudent to set up CI. I've run it locally on my system and it works for me, but we'll see how it fares on the CI system. > I made a recommendation for a different model with how to do the CI, > but it's super minor and can be done later. Basically, if we create > a new job for SHA-256 mode, then we can more quickly identify when > a test failure is due to that toggle and not other optional GIT_TEST_* > variables. I think that's a good suggestion, and I'm familiar enough with GitHub Actions that I think I can set up an additional job. If I reroll, I'll try to squash such a change in. > I hope to play around with SHA256-enabled repos a bit later, to see > if I can find any issues poking around on my own. I doubt I will, > with how thoroughly you modified the test suite. For folks who are looking for a more convenient way to get patches, you're welcome to grab them from the transition-stage-4 branch on https://github.com/bk2204/git.git or https://git.crustytoothpaste.net/git/bmc/git.git. The GitHub URL has slightly more bandwidth and a generally better uptime, since I don't live in a datacenter. -- brian m. carlson: Houston, Texas, US
Attachment:
signature.asc
Description: PGP signature
