On 7/9/2020 10:46 PM, brian m. carlson wrote: > This is the final part required for the stage 4 implementation of > SHA-256. WOOHOO! What a milestone! As usual, your commits are excellently organized and clear. I could not find any fault in any of them. The proof is really in the pudding: does this pass the test suite when GIT_TEST_DEFAULT_HASH=sha256? You add that as a mode to the CI scripts, so we will know. I made a recommendation for a different model with how to do the CI, but it's super minor and can be done later. Basically, if we create a new job for SHA-256 mode, then we can more quickly identify when a test failure is due to that toggle and not other optional GIT_TEST_* variables. I hope to play around with SHA256-enabled repos a bit later, to see if I can find any issues poking around on my own. I doubt I will, with how thoroughly you modified the test suite. Thanks for this incredible achievement! -Stolee
