Derrick Stolee <stolee@xxxxxxxxx> writes: > On 6/17/2020 5:14 AM, Abhishek Kumar wrote: >> The struct commit is used in many contexts. However, members >> `generation` and `graph_pos` are only used for commit graph related >> operations and otherwise waste memory. >> >> This wastage would have been more pronounced as we transition to >> generation nuber v2, which uses 64-bit generation number instead of >> current 32-bits. > > Thanks, Szeder (CC'd) for the quality review in the previous > versions. I manually built and tested all of the patches here > and verified they passed all tests. > > I think this series is in good shape. Thank you to all who are involved in this topic. Looking good.