The struct commit is used in many contexts. However, members generation and graph_pos are only used for commit-graph related operations and otherwise waste memory. This wastage would have been more pronounced as transistion to generation number v2, which uses 64-bit generation number instead of current 32-bits. The third patch ("commit: convert commit->graph_pos to a slab", 2020-06-04) is currently failing diff-submodule related tests (t4041, t4059 and t4060) for gcc [1]. I am going to send a second version soon, fixing that. [1]: https://travis-ci.com/github/abhishekkumar2718/git/jobs/343441189 Abhishek Kumar (3): commit: introduce helpers for generation slab commit: convert commit->generation to a slab commit: convert commit->graph_pos to a slab alloc.c | 2 - blame.c | 2 +- bloom.c | 6 +- commit-graph.c | 116 +++++++++++++++++++++------- commit-graph.h | 8 ++ commit-reach.c | 50 ++++++------ commit.c | 6 +- commit.h | 6 -- contrib/coccinelle/generation.cocci | 12 +++ contrib/coccinelle/graph_pos.cocci | 12 +++ revision.c | 16 ++-- 11 files changed, 158 insertions(+), 78 deletions(-) create mode 100644 contrib/coccinelle/generation.cocci create mode 100644 contrib/coccinelle/graph_pos.cocci -- 2.27.0