Hi Abhishek, I am so excited that you are working on this, and welcome to Git! This change will make a meaningful difference for us at GitHub (who use commit graphs extensively), and it sounds like they will even make a larger difference with your later changes. I was out of the office last week, and so I hadn't gotten a chance to review the first version of this series, but I'll review v2 now... On Mon, Jun 08, 2020 at 01:02:33AM +0530, Abhishek Kumar wrote: > The struct commit is used in many contexts. However, members > `generation` and `graph_pos` are only used for commit graph related > operations and otherwise waste memory. Thanks, Taylor
