On 2020-06-10 at 21:19:22, Don Goodman-Wilson via GitGitGadget wrote:
> + /* prepend "refs/heads/" to the branch name */
> + prefixed = xstrfmt("refs/heads/%s", branch_name);
> + if (check_refname_format(prefixed, 0))
> + die(_("invalid default branch name: '%s'"), branch_name);
I'm glad to see this part and a check for it in the test below. We
wouldn't want a typo to create a broken branch name.
> +test_expect_success 'invalid custom default branch name' '
> + test_must_fail env GIT_TEST_DEFAULT_BRANCH_NAME="with space" \
> + git init custom-invalid 2>err &&
> + test_i18ngrep "invalid default branch name" err
> +'
> +
--
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
Attachment:
signature.asc
Description: PGP signature
