On Wed, May 27, 2020 at 06:47:30PM +0200, Christian Couder wrote: > This patch series is the second part of an effort to move all static > variables in 'upload-pack.c' into 'struct upload_pack_data'. > > It is based on 'cc/upload-pack-data' which contains "part 1" of this > effort. (See also: https://lore.kernel.org/git/20200515100454.14486-1-chriscool@xxxxxxxxxxxxx/) > > A part 3 will follow with the rest of the patches needed to get rid of > the static variables left after this patch series. Thanks again for working on this. It mostly looks good, but I left a few comments, mostly about commit messages or comments. :) One thing I think we _could_ do is to switch v2 to only reading the config once, instead of once per request. And then all of those config values could remain where they are, as they wouldn't need to be cleared or reset. But I doubt the cost of parsing config per-request is noticeable in practice, so I'm happy with it either way. -Peff
