On 2020-05-19 21:39:02+0200, Laurent Arnoud <laurent@xxxxxxxxxx> wrote:
>
> +check_diff_relative_option () {
> + dir=$1
> + shift
> + expect=$1
> + shift
> + relative_opt=$1
> + shift
> + test_expect_success "config diff.relative $relative_opt -p $*" "
> + short_blob=$(git rev-parse --short $blob_file2) &&
We need to quote the first dollar, in order to run that command
inside the test. Current version will run that git-rev-parse
outside of the test and interpolated into this command by outer shell.
short_blob=\$(git rev-parse --short $blob_file2) &&
Sorry, I didn't think about this earlier.
> + test_expect_success "config diff.relative $relative_opt -p $*" "
> + short_blob_file1=$(git rev-parse --short $blob_file1) &&
> + short_blob_file2=$(git rev-parse --short $blob_file2) &&
This test also needs to quote that dollar.
Beside that, LGTM.
--
Danh
