Đoàn Trần Công Danh <congdanhqx@xxxxxxxxx> writes: >> Documentation/config/diff.txt | 4 ++ >> Documentation/diff-options.txt | 3 ++ >> diff.c | 16 ++++-- >> t/t9904-diff-relative-config.sh | 93 +++++++++++++++++++++++++++++++++ > > I think t99?? is used for miscellaneous tests. > > To me, diff-relative things should be tested in t4045-diff-relative.sh Right. Thanks for carefully checking what we already have. >> diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt >> index bb31f0c42b..1b279904eb 100644 >> --- a/Documentation/diff-options.txt >> +++ b/Documentation/diff-options.txt >> @@ -651,6 +651,9 @@ ifndef::git-format-patch[] >> not in a subdirectory (e.g. in a bare repository), you >> can name which subdirectory to make the output relative >> to by giving a <path> as an argument. >> +--no-relative:: > > Please merge this option with `--relative[=<path>]` above. > And says something likes: > > `--no-relative` can be used to countermand > both `diff.relative` and previous `--relative` This, and all the rest of comments are quite good. Thanks for helping.