-Cc: chriscool@xxxxxxxxxxxxx (seems redundant; Also, .mailmap confirms
that christian.couder@xxxxxxxxx is Christian's preference)
On 14-05-2020 01:47, Shourya Shukla wrote:
The extra '$branch' on line 752 was because of Christian's help after
reference from TLDP's Parameter Subsitution documentation:
https://www.tldp.org/LDP/abs/html/parameter-substitution.html
For those who lack the context, during the conversion of the script
Shourya faced an issue where the '--branch' argument did not work as
expected. He described the issue in a private e-mail where Christian
pointed out the following (quoting his reply hoping he doesn't mind):
> On Tue, May 12, 2020 at 5:55 PM Christian Couder
<christian.couder@xxxxxxxxx> wrote:
>>
>> In your commit (in submodule.sh line 781) there is:
>>
>> `git ${wt_prefix:+-C "$wt_prefix"} ${prefix:+--super-prefix
>> "$prefix"} submodule--helper set-branch ${GIT_QUIET:+--quiet}
>> ${branch:+--branch} ${default:+--default} -- "$@"`
>
> Actually the issue might come from the above. I think it should use
${branch:+--branch $branch} instead of ${branch:+--branch}.
>
> See: https://www.tldp.org/LDP/abs/html/parameter-substitution.html
That's why Shourya mentions the '$branch' as extra. Of course, that's
how it is supposed to be in the first place :)
--
Sivaraam
