Sibi Siddharthan <sibisiddharthan.github@xxxxxxxxx> writes: >> All of these compatibility stuff makes sense, but how do we decide >> where to draw the line between the checks we saw added in [01/11] >> and the checks added here? It feels pretty arbitrary to me and if >> that is the case, perhaps we want to move all the "add checks" to a >> commit separate from [01/11] (whose primary purpose is to add the >> basic rules without these build tweaks in the file at the final >> place)? >> > > The checks are added on a "demand" based the target platform. > In the future, if apple support is needed, we need to add ST_TIMESPEC checks. Well, let's ask a related question then. Given that the primary reason why the project may be interested in adding cmake-based build system is because of its support for Windows build, how much smaller would this 11-patch series can become if we discard support for any platforms other than Windows? Let's say we add support for other platforms only after the series proves capable to build on/for Windows by going through the usual "queued in 'pu', merged to 'next' and then down to 'master'" route and appears in a tagged release. Would it reduce the time we need to spend before seeing a cmake-based build for Windows by doing so?
