Re: Shell script cleanups/style changes?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano <gitster@xxxxxxxxx> writes:

>  (1) that shell does not even grok $(cmd) substitution.
>
>      I won't accept a half-baked patch that replaces "$(" with a
>      backtick and matching ")" with another backtick.  You need
>      to at least make sure your interpolated variables within
>      the backtick pair work sensibly, and you haven't broken
>      existing nesting of command interpolations, if any.  I do
>      not even want to inspect, comment on and reject that kind
>      of changes.  Quite frankly, it's not worth my time.

And that's actually not even _half_ of the deal: we are talking about
pandering to legacy shells here, and the amount of variance of just
what level of quoting/backslashing is needed on the inside of `...` in
order to get stuff through with just the right level of quoting is
actually stunning.

I've had my fair share of bad surprises with portable scripts.
Getting a backquote mechanism running on one shell does not mean it
will work on another.  Basically, you have to forego nesting stuff and
split it out into small units in separate commands.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux