Re: Shell script cleanups/style changes?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



David Kastrup <dak@xxxxxxx> writes:

> Sure.  What about the git-rebase line using $(($end - $msgnum)) ?
> That's even more risque than ##.

Is it really risque?  I do not think we have heard trouble with
the arith expansion from anybody.  A few mistakes in the past
made that said things like:

	$((end - 1))	    ;# wrong... say "$end" if you mean variable
	$((cd ...; pwd))    ;# wrong... say $( (...)) if command substitution
                             # that involves subshell

but I think we fixed them.

> Understood.  But using ${...#...} and ${...:+...} does not exactly
> seem to be news in the git code base.  Even though we have the claim
> that Solaris' sh won't deal with the former.

I do not think we have trouble with ${parameter#word}.  Much
less with ${parameter+word}; it has been in /bin/sh forever.

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux