On Thu, May 7, 2020 at 8:32 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Christian Couder <christian.couder@xxxxxxxxx> writes: > > > It's ok to refer to a previous commit, but I think it would be better > > if you could repeat a bit the reasons why removing the > > fetch_if_missing global is a good idea, and not just rely on the > > previous commit. > > > > "it is plausible" also doesn't make it very clear that it's what the > > patch is actually doing. > > I had the same reaction. You could even write a random gibberish in > your patch and write "it's plausible this set of random changes made > without understanding what is going on in the current code might > have some chance to work" in your log message, and we would not even > want to touch such a patch with 10-foot pole. > > The proposed log message above unfortunately makes this patch > indistinguishable from such a trash, unless we follow the codepaths > that are *not* touched by this patch and think about ramifications > of the removal *ourselves*. In other words, it does nothing to help > the readers to support the change. > I understand it must be too hard for you to deal with such [trash]patches. My apologies. Will improve in next revision Thanks, Hariom
