On Mon, Apr 20, 2020 at 9:57 PM Hariom Verma via GitGitGadget <gitgitgadget@xxxxxxxxx> wrote: > > From: Hariom Verma <hariom18599@xxxxxxxxx> > > Commit 6462d5e ("fetch: remove fetch_if_missing=0", 2019-11-08) > strove to remove the need for fetch_if_missing=0 from the fetching > mechanism, so it is plausible to attempt removing fetch_if_missing=0 > from fetch-pack as well. It's ok to refer to a previous commit, but I think it would be better if you could repeat a bit the reasons why removing the fetch_if_missing global is a good idea, and not just rely on the previous commit. "it is plausible" also doesn't make it very clear that it's what the patch is actually doing. Thanks, Christian.