On Fri, May 08, 2020 at 08:46:58AM -0700, Junio C Hamano wrote: > Even though the log message itself got a lot better explaining the > nature of the issue, I do not think the title of the patch does a > good job explaining what it is about to the readers of shortlog. > > "fix" is a meaningless word in a bugfix patch, and it does not make > it clear what bad effect of the original code had by not giving a > clean-slate "options" variable to the second invocation of the > callchain. > > Is it that the server side was incapable of serving a follow-up > fetch request in the same process when protocol v2 was in use? > Perhaps > > upload-pack: allow follow-up fetch in protocol v2 > > or something? Yeah, I agree that's better. Maybe even: upload-pack: clear filter_options for each v2 fetch command which is more direct (we already allow follow-up fetches; they just don't work sometimes) and makes it clear that this is about fixing the filter feature with v2. -Peff
