On Fri, May 08, 2020 at 10:01:15AM +0200, Christian Couder wrote: > The changes since the previous RFC version are the following: > > - now filter_options is part of struct upload_pack_data as > suggested by Peff and Taylor > - improved commit message > - updated comment before the test that used to fail Thanks, this version looks good to me. > static void create_pack_file(const struct object_array *have_obj, > - const struct object_array *want_obj) > + const struct object_array *want_obj, > + struct list_objects_filter_options *filter_options) I had hoped that stuffing it into upload_pack_data would require fewer changes passing it around, but I guess many of these functions don't know about upload_pack_data in the first place. Oh well. I think this is the best we can do for now. In the long run we'd perhaps want to take upload_pack_data there, but it wouldn't help until the v0 path also uses that struct. -Peff
