Re: [PATCH v2 1/2] t5537: use test_write_lines, indented heredocs for readability

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Taylor Blau <me@xxxxxxxxxxxx> writes:

> Subject: [PATCH] t5537: use test_write_lines, indented heredocs for readability

Assuming that "indented" is not a verb in the past tense, but
adjective on the noun "heredocs", this reads well, but "s/,/ and/"
would make it more clear in that case.  Or "for readability, use X
and indent Y" would work equally well.

But the original is probably OK as-is.

> -	cat <<EOF >expect &&
> -4
> -3
> -EOF
> +	test_write_lines 4 3 >expect &&

Yeah, becomes much nicer with test_write_lines.

Thanks.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux