Taylor Blau wrote: > Subject: [PATCH] t5537: use test_write_lines, indented heredocs for readability > > A number of spots in t5537 use the non-indented heredoc '<<EOF' when > they would benefit from instead using '<<-EOF' or simply > test_write_lines. > > In preparation for adding new tests in a good style and being consistent > with the surrounding code, update the existing tests to improve their > readability. > > Suggested-by: Junio C Hamano <gitster@xxxxxxxxx> > Signed-off-by: Taylor Blau <me@xxxxxxxxxxxx> > --- > t/t5537-fetch-shallow.sh | 70 ++++++++++------------------------------ > 1 file changed, 17 insertions(+), 53 deletions(-) The commit message is missing the mention of \EOF quoting. See "git log --grep='modernize style'" for some examples about how to write this kind of commit message without it getting tedious. That said, I think it's fine --- just mentioning that for the future. Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx>
