Denton Liu <liu.denton@xxxxxxxxx> writes: > Hannes suggested that we should drop the tip commit of this series[1] > and I tend to agree with him. Aside from that, though, the series is > ready to go. > > (I could improve 3/8 as suggested here[2] but I'll throw it in the next > series instead since I'm trying to get into the habit of not adding in > unrelated patches.) > > [1]: https://lore.kernel.org/git/6cfa2c447e1196d6c4325aff9fac52434d10fda8.1587372771.git.liu.denton@xxxxxxxxx/ > [2]: https://lore.kernel.org/git/90faeb7a-1c6a-3fc6-6410-5e264c9340e8@xxxxxxxx/ I agree with you two that test_must_fail may make sense with these __git_foo helpers used in the completion. It is a bit of shame that there is no opportunity to leave the reasoning behind the decision for later developers, other than in the discussion thread. I agree that 3/8 is good as-is in this series. Thanks.
