On Mon, Apr 20, 2020 at 4:09 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes: > > Hmm, this doesn't look like 'test_cmp' mentioned in the commit message. > > Yeah, the other hunk is about test_cmp and this hunk is about > svn_cmd. The stated rationale applies to both wrappers, I think. > > Subject: [PATCH 6/8] t9164: use test_must_fail only on git > > The `test_must_fail` function should only be used for git commands; > we are not in the business of catching segmentation fault by external > commands. Shell helper functions test_cmp and svn_cmd used in this > script are wrappers around external commands, so just use `! cmd` > instead of `test_must_fail cmd` > > perhaps, without any change to the code? That sounds fine.
