"Johannes Schindelin via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > We have this feature on Windows where the files starting with a dot can be > marked hidden (whether a file is hidden by default or not is a matter of > naming convention on Unix, but it is an explicit flag on Windows). This > patch improves the regression tests of this feature, and it has been carried > in Git for Windows for over three years. > > Junio, I followed your advice, and did one more thing: the function is now > renamed also only in 3/3. Looks good. I would have renamed it when making it global, exactly for the reason you stated in [3/3], but it's not like we would merge only the first two without the fixup, so it does not matter in practice (as long as other people won't pick up a bad habit from the example, that is). Thanks. Let's start merging a lot of things down to 'next'.