On Thu, Apr 09, 2020 at 10:00:46AM -0400, Derrick Stolee wrote: > >> So our issue was really that the partial clone prefetch logic was just > >> overly aggressive. > > > > Right, but I'm not sure how this patch could ever have helped, since > > it's just setting a variable to the value it _should_ have already had. > > > > Or do you just mean that the issue would have gone away with Jonathan's > > patch to make the prefetching less aggressive? > > Yes, with Jonathan's patch we stop downloading blobs during Bloom filter > computations. The patch this is "replacing" disabled that download in a > different way, depending only on if detect_renames is false and the diff > output doesn't need file contents. (Jonathan's is better.) OK. I'm willing to leave it there, but I'm still puzzled as to why the original patch would have done anything based on detect_renames, which would always be false. -Peff
