On Thu, Apr 09, 2020 at 07:56:43AM -0400, Derrick Stolee wrote: > > So we really aren't detecting renames in the first place! And indeed, > > checking diffopt.detect_rename shows that it is unset. So I'm curious if > > there is a case where that would not be true. I _think_ it would only be > > true in a program which ran init_diff_ui_defaults(), but never in > > git-commit-graph. > > So our issue was really that the partial clone prefetch logic was just > overly aggressive. Right, but I'm not sure how this patch could ever have helped, since it's just setting a variable to the value it _should_ have already had. Or do you just mean that the issue would have gone away with Jonathan's patch to make the prefetching less aggressive? -Peff
