Re: [PATCH v4 1/1] midx.c: fix an integer overflow

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v4 1/1] midx.c: fix an integer overflow
From: Junio C Hamano <gitster@xxxxxxxxx>
Date: Thu, 26 Mar 2020 16:27:16 -0700
Cc: Jeff King <peff@xxxxxxxx>, git@xxxxxxxxxxxxxxx, Derrick Stolee <dstolee@xxxxxxxxxxxxx>, William Baker <William.Baker@xxxxxxxxxxxxx>, Damien Robert <damien.olivier.robert+git@xxxxxxxxx>
In-reply-to: <20200326213534.399377-1-damien.olivier.robert+git@gmail.com> (Damien Robert's message of "Thu, 26 Mar 2020 22:35:34 +0100")
References: <20200326213534.399377-1-damien.olivier.robert+git@gmail.com>
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Damien Robert <damien.olivier.robert@xxxxxxxxx> writes:

> When verifying a midx index with 0 objects, the
>     m->num_objects - 1
> overflows to 4294967295.

I think this is underflow & wraparound, but I'll let it pass ;-)

The patch looks good; will queue.

Thanks.

Follow-Ups:
- Re: [PATCH v4 1/1] midx.c: fix an integer overflow
  - From: Damien Robert

References:
- [PATCH v4 1/1] midx.c: fix an integer overflow
  - From: Damien Robert

Prev by Date: Re: [PATCH] connected: always use partial clone optimization
Next by Date: Re: [PATCH v2] Fix dir sep handling of GIT_ASKPASS on Windows
Previous by thread: [PATCH v4 1/1] midx.c: fix an integer overflow
Next by thread: Re: [PATCH v4 1/1] midx.c: fix an integer overflow
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]

Powered by Linux