On Wed, Mar 25, 2020 at 5:35 PM Torsten Bögershausen <tboegi@xxxxxx> wrote: > > Thanks for working on this. I have 1 or 2 nits/questions, please see below. > > On Wed, Mar 25, 2020 at 01:45:10PM +0000, András Kucsma via GitGitGadget wrote: > > From: Andras Kucsma <r0maikx02b@xxxxxxxxx> > > > > On Windows with git installed through cygwin, GIT_ASKPASS failed to run > > My understanding is, that git under cygwin needs this patch (so to say), > but isn't it so, that even Git for Windows has the same issue ? > The headline of the patch and the indicate so. Git for Windows does not have this issue, because there GIT_WINDOWS_NATIVE is defined, which is not true under Cygwin: https://github.com/git/git/blob/274b9cc2/git-compat-util.h#L157-L165 You can see in start_command() that there are separate implementations based on GIT_WINDOWS_NATIVE. The problematic code is in prepare_cmd, which is not called in the branch where GIT_WINDOWS_NATIVE is defined: https://github.com/git/git/blob/274b9cc2/run-command.c#L740 This means, that cygwin is running in the Unix-like branch of the code, even though it supports backslashes in its paths.
